Fix version check crash #6158
Merged
Fix version check crash #6158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build Rubberduck 2.5.9.6295 completed (commit 9663043b38 by @retailcoder) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #6158 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 4 4
Lines 413 413
Branches 28 28
=======================================
Hits 403 403
Misses 6 6
Partials 4 4 |
retailcoder
commented
Sep 22, 2023
| @@ -53,40 +53,31 @@ protected override async void OnExecute(object parameter) | |||
| Logger.Info("Executing version check..."); | |||
|
|
|||
| var tokenSource = new CancellationTokenSource(TimeSpan.FromSeconds(5)); | |||
| await _versionCheck | |||
| .GetLatestVersionAsync(settings, tokenSource.Token) | |||
| .ContinueWith(t => | |||
There was a problem hiding this comment.
This was the problem; the service's return value should have been awaited here, not task-continued like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DockableWindowHost in RD2.x is still consistently throwing on my machine (interestingly, not RD3's), so I couldn't fully test the initialization sequence - but the version check command is should no longer throw.
Bonus, made the API base url configurable via a hidden
<ApiBaseUrl>setting in the<GeneralSettings>section; value must end with a slash, and the reason it's there is because the Azure-hosted API URL contains the deployment timestamp, which means it's going to change whenever a new build is deployed, so whether it's GoDaddy returning 503 or Azure returning 404 the version check is going to end up failing no matter what - hence making it catch and log (at warn level) any exceptions thrown.Having the ability to set the base URL without needing to re-install RD felt like a good idea.
Closes #6157
Closes #6156
Closes #6153
Closes #6152